feat: Apply stdArray to the rest of the code#3881
Open
Conversation
arng40
requested review from
CusiniM,
Guotong-Ren,
MelReyCG,
OmarDuran,
acitrain,
castelletto1,
corbett5,
dkachuma,
frankfeifan,
jhuang2601,
kimtaeho07,
matteofrigo5,
paveltomin,
rrsettgast,
sframba,
victorapm and
wrtobin
as code owners
…rray-bounds-checking
arng40
added
type: feature
…rray-bounds-checking
arng40
changed the title
dkachuma
approved these changes
Feb 5, 2026
Comment on lines
+4
to
+5
| #include <array> | ||
| #include <cstddef> |
Contributor
There was a problem hiding this comment.
Suggested change
| #include <array> | |
| #include <cstddef> |
| numInternalNodesPerEdge, numNodesPerEdge, globalNodeOffset, glCoords, localNodeOffset, order]( localIndex const iter_edge ) | ||
| { | ||
| std::unordered_map< std::array< localIndex, 6 >, localIndex, NodeKeyHasher< localIndex > > nodeIDs; | ||
| std::unordered_map< stdArray< localIndex, 6 >, localIndex, NodeKeyHasher< localIndex > > nodeIDs; |
Contributor
There was a problem hiding this comment.
Don't we have a wrapper form std::unordered_map?
…EV/GEOS into feat/dudes/add-code-rules
…rray-bounds-checking
…feat/dudes/apply-array-bounds-checking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces wrappers for array-type containers, replacing the use of std::array to the geos repo . stdArray is introduced, which offer bounds checking via a modified operator [] .