feat: Error reporting at the end of the simulatiuon #3929
Open
arng40 wants to merge 348 commits intofeat/dudes/perforations-table-detailfrom
Open
feat: Error reporting at the end of the simulatiuon #3929arng40 wants to merge 348 commits intofeat/dudes/perforations-table-detailfrom
arng40 wants to merge 348 commits intofeat/dudes/perforations-table-detailfrom
Conversation
…mandinehry/create-yaml-file-and-structure
…t-test + testing GEOS_ERROR
…unit test separation for multiple EXPECT_EXIT
…upported by fmt for now)
…ASSERT and GEOS_THROW are now compatible with context parameters)
…y/create-yaml-file-and-structure
…y/create-yaml-file-and-structure
…file-and-structure-2' into refactor/dudes/error-context
…y/create-yaml-file-and-structure-2
MelReyCG
requested changes
Mar 18, 2026
Contributor
MelReyCG
left a comment
MelReyCG
left a comment
There was a problem hiding this comment.
can we see a real case sample?
| tableLayout.addColumn( "Types" ); | ||
|
|
||
| // fill header | ||
| for( size_t msgTypeIdx = (size_t) MsgType::Error; msgTypeIdx != (size_t)MsgType::Undefined; msgTypeIdx++ ) |
Contributor
There was a problem hiding this comment.
Do as I did in my PR for the -d:
Suggested change
| for( size_t msgTypeIdx = (size_t) MsgType::Error; msgTypeIdx != (size_t)MsgType::Undefined; msgTypeIdx++ ) | |
| for( size_t msgTypeIdx = 0; msgTypeIdx < (size_t)MsgType::Count; msgTypeIdx++ ) |
…tail' into feat/dudes/warning-report
commit b962b2c Author: arng40 <arnaud.dudes@capgemini.com> Date: Tue Mar 31 10:52:52 2026 +0200 :coffin: dead code & spaces commit dfe0619 Author: arng40 <arnaud.dudes@capgemini.com> Date: Tue Mar 31 10:51:32 2026 +0200 :art: format code commit 55aff05 Merge: ee7d7da ba863d7 Author: arng40 <arnaud.dudes@capgemini.com> Date: Tue Mar 31 10:51:05 2026 +0200 Merge branch 'feat/dudes/perforations-table-detail' of https://github.com/GEOS-DEV/GEOS into feat/dudes/perforations-table-detail commit ee7d7da Author: arng40 <arnaud.dudes@capgemini.com> Date: Tue Mar 31 10:50:50 2026 +0200 :bug: local scope for globalWellElemIndices commit ba863d7 Merge: 0d22428 510dc76 Author: Arnaud DUDES <155963334+arng40@users.noreply.github.com> Date: Tue Mar 31 10:34:16 2026 +0200 Merge branch 'develop' into feat/dudes/perforations-table-detail commit 0d22428 Merge: 17538bd 23a5694 Author: arng40 <arnaud.dudes@capgemini.com> Date: Mon Mar 30 18:01:56 2026 +0200 Merge branch 'feat/dudes/perforations-table-detail' of https://github.com/GEOS-DEV/GEOS into feat/dudes/perforations-table-detail commit 17538bd Author: arng40 <arnaud.dudes@capgemini.com> Date: Mon Mar 30 18:01:44 2026 +0200 :recycle: relocated in perfo data + renaming commit 23a5694 Merge: 1181253 acd7cc5 Author: MelReyCG <122801580+MelReyCG@users.noreply.github.com> Date: Mon Mar 30 17:12:21 2026 +0200 Merge branch 'develop' into feat/dudes/perforations-table-detail commit 1181253 Author: arng40 <arnaud.dudes@capgemini.com> Date: Mon Mar 30 17:11:47 2026 +0200 :art: added boolean array for perfo availibility commit a302088 Author: MelReyCG <melvin.rey@capgemini.com> Date: Mon Mar 30 11:19:58 2026 +0200 🎨 spaces commit 935d117 Author: arng40 <arnaud.dudes@capgemini.com> Date: Mon Mar 30 10:12:28 2026 +0200 :art: improve testMpiTable Cond commit 7d6249d Author: arng40 <arnaud.dudes@capgemini.com> Date: Mon Mar 30 10:12:03 2026 +0200 :art: update perdoration sorting cond commit 81a96b2 Author: arng40 <arnaud.dudes@capgemini.com> Date: Mon Mar 30 10:10:21 2026 +0200 :coffin: :label: remove dead code, update types commit bdc15ec Author: arng40 <arnaud.dudes@capgemini.com> Date: Fri Mar 27 17:12:37 2026 +0100 :truck: move declaration outside hpp commit ecef467 Author: arng40 <arnaud.dudes@capgemini.com> Date: Fri Mar 27 11:15:41 2026 +0100 :green_heart: fix CI build
MelReyCG
changed the base branch from
develop
to
feat/dudes/perforations-table-detail
MelReyCG
requested review from
frankfeifan,
herve-gross and
jhuang2601
as code owners
MelReyCG
reviewed
Mar 31, 2026
Comment on lines
+150
to
+151
| LogHistory const & getLoggerReportData() const | ||
| {return loggerMsgReportData;} |
Contributor
There was a problem hiding this comment.
Suggested change
| LogHistory const & getLoggerReportData() const | |
| {return loggerMsgReportData;} | |
| LogHistory const & getLoggerHistory() const | |
| {return m_history;} |
Comment on lines
+140
to
+141
| stdUnorderedMap< LogRecord::Key, LogRecord::Values, | ||
| LocationKeyHash > m_diagnosticHistory; |
Contributor
There was a problem hiding this comment.
Suggested change
| stdUnorderedMap< LogRecord::Key, LogRecord::Values, | |
| LocationKeyHash > m_diagnosticHistory; | |
| stdUnorderedMap< LogRecord::Key, LogRecord::Values, LocationKeyHash > m_diagnosticHistory; |
|
|
||
| void LogHistory::gatherRecordsRank0() | ||
| { | ||
| LogHistory & history = ErrorLogger::global().getLoggerReportData(); |
Contributor
There was a problem hiding this comment.
This is critical to use this to retrieve the instance instead of that syntax.
| /** | ||
| * @return The const historical diagnostic | ||
| */ | ||
| auto const & getDiagnosticHistory() const |
Contributor
There was a problem hiding this comment.
Not a big fan of the auto here
Contributor
There was a problem hiding this comment.
The LogRecord privateness is violated here.
TableTextFormatter may be a friend class and this method may be removed.
MelReyCG
reviewed
Mar 31, 2026
Comment on lines
+123
to
+134
| struct LocationKeyHash | ||
| { | ||
|
|
||
| size_t operator()( LogRecord::Key const & key ) const noexcept | ||
| { | ||
| size_t h1 = std::hash< string >{} (key.m_filename); | ||
| size_t h2 = std::hash< integer >{} (key.m_lineId); | ||
|
|
||
| return h1 ^ (h2 << 1); | ||
| } | ||
|
|
||
| }; |
…EV/GEOS into feat/dudes/warning-report
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will be merged after : #3902
Located after MemoryStatsOutput :
Ex :