refactor: Add a logger for all the vtk filter of geos-processing and all the plugin of geos-pv#178
Merged
paloma-martinez merged 30 commits intomainfrom Dec 1, 2025
Conversation
added 10 commits
November 17, 2025 15:30
…ilterAndPlugins Update to the last version of the main
…ilterAndPlugins Update to the last version of the main
RomainBaville
added
type: cleanup
test-geos-integration
added 2 commits
November 18, 2025 10:40
…ilterAndPlugins Update to the last version of the main
RomainBaville
added
flag: ready for review
and removed
test-geos-integration
RomainBaville
changed the base branch from
main
to
RomainBaville/refactor/RefactorFilterWithoutVTKPythonAlgorytmBase
added 2 commits
November 20, 2025 11:25
paloma-martinez
approved these changes
Nov 21, 2025
RomainBaville
added
DO NOT MERGE!
test-geos-integration
jafranc
requested changes
Nov 24, 2025
Collaborator
jafranc
left a comment
jafranc
left a comment
There was a problem hiding this comment.
I think the try-except block there is some refactoring
Comment on lines
+44
to
+54
|
|
||
|
|
||
| class RaiseMergeBlocks( TestCase ): | ||
| """Test failure on empty multiBlockDataSet.""" | ||
|
|
||
| def test_TypeError( self ) -> None: | ||
| """Test raise of TypeError.""" | ||
| multiBlockDataset = vtkMultiBlockDataSet() # should fail on empty data | ||
| if Version( vtk.__version__ ) < Version( "9.5" ): | ||
| with pytest.raises( VTKError ): | ||
| multiblockModifiers.mergeBlocks( multiBlockDataset, True ) |
Contributor
Author
There was a problem hiding this comment.
As I changed the filter MergeBlockEnhanced, its test needed to be change to, this test was usless with the new implementation of the filter so I move it to the test of the function mergeBlock
| f"The { self.piece } attributes { attributesAlreadyInMeshTo } are already present in the final mesh." ) | ||
| self.logger.error( f"The filter { self.logger.name } failed." ) | ||
| return False | ||
| try: |
Collaborator
There was a problem hiding this comment.
I am not sure of try except and raise in the try.
Raising here is fine but capturing should be done in the caller or caller's caller tbf
Contributor
Author
There was a problem hiding this comment.
In this pr I wanted to add or update the logger. To do that I used the same scheme try/except in all the plugins and filters. But your are right, the filtre may not use try/except. To keep "small" and "unitary" pr, I think it can be done in another pr (see pr #185 )
| self.logger.error( f"The new attribute { self.newAttributeName } has not been added." ) | ||
| self.logger.error( f"The filter { self.logger.name } failed." ) | ||
| return False | ||
| try: |
added 2 commits
November 24, 2025 11:40
Base automatically changed from
RomainBaville/refactor/RefactorFilterWithoutVTKPythonAlgorytmBase
to
main
November 25, 2025 09:21
jafranc
approved these changes
Dec 1, 2025
paloma-martinez
deleted the
RomainBaville/refactor/AddAndCheckLoggerForFilterAndPlugins
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the context of the code refactoring, this pr aims at creating a logger for all the vtk filters and all the ParaView plugins implemented if absent.
This pr follows the pr #181.
This pr will not uniformize the output message of these logger. It will be done in another pr following the issue #184