feat: add boundaryDistance option to checkInternalTags#244
Open
feat: add boundaryDistance option to checkInternalTags#244
Conversation
jafranc
added
flag: ready for review
test-geos-integration
jafranc
reviewed
Mar 26, 2026
| return { 'bottom': bottomSurface, 'top': topSurface } | ||
|
|
||
|
|
||
| def __getBoundarySurfaceForMode( classified: Dict[ str, vtk.vtkPolyData ], mode: str ) -> vtk.vtkPolyData: |
Collaborator
There was a problem hiding this comment.
could mode be a StrEnum ?
| cell = boundarySurface.GetCell( i ) | ||
|
|
||
| # Get min/max Z of all points in the cell | ||
| minZ = float( 'inf' ) |
Collaborator
There was a problem hiding this comment.
as numpy is imported, why not using it here ?
| return volumeNeighbors | ||
|
|
||
|
|
||
| def __extractVolumeMeshBoundary( mesh: vtk.vtkUnstructuredGrid, volumeCells: set[ int ] ) -> vtk.vtkPolyData: |
Collaborator
There was a problem hiding this comment.
why not vtkDataSetSurfaceFilter and its fast mode ?
| return boundarySurface | ||
|
|
||
|
|
||
| def __classifyBoundarySurfaceByLocation( boundarySurface: vtk.vtkPolyData ) -> Dict[ str, vtk.vtkPolyData ]: |
Collaborator
There was a problem hiding this comment.
I am more use to sort by normal variation with vtkPolyDataNormals() but isn't this also selecting part of your other boundary faces unless your threshold is lower than the lowest element radius on those ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP