Conversation
|
CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details. |
|
ok to test |
1 similar comment
|
ok to test |
|
CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details. |
|
@gloob - there's a fix in Infusion core now for FLUID-5940 but https://issues.gpii.net/browse/GPII-1994 is now a new blocker assigned to @kaspermarkus |
|
CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details. |
|
I've updated this with current master to avoid conflicts. The current status of the blockers we have is the following:
BTW, I've reverted the minimum required version of node in universal and linux BUT since we're having this particular problem with windows, I recommend to keep the node version requirement to 6.x so users don't need to manually update npm to get it working with node 4.x. |
* upstream/master: GPII-1108: Merged up with master GPII-1540: Fixed indentation. GPII-1540: Make test-window.exe build automatically GPII-1540: Removed the test application executable GPII-1540: Flipped options.force to option.cleanOnly. Off by default feels better. GPII-1540: Unit tests for closeProcessByName always pass Waiting for process start sometimes triggers just before the window is created. GPII-1540: Unit tests for closeProcessByName Created test-window, a dummy application that creates a window for testing. GPII-1540: rollback; Put findProcessByName back to how it was. It turned out to be better to enumerate the windows, rather than enumerate every thread. GPII-1540: Made the process enumeration in findProcessByName re-usable. Refactored it out into eachProcess, in preparation for a "get the windows of each process" routine. GPII-1540: Merge from master GPII-1540: Implemented closeProcessByName. Terminate a process less aggressively. GPII-1828: Allows for retrieval of updated env vars GPII-1108: Fixed logic for allowing deletion of subkeys of nonexistent parents in the registry to be a noop
|
CI job passed. |
|
I've updated the reference to universal and added nan as dependency. I've also created an issue (https://issues.gpii.net/browse/GPII-2037) to remove our dependency with nan when the issue we have is fixed upstream. |
This isn't ready yet until these two issues are solved:
Can be tested by applying the following patch: NO LONGER NEEDED
I'm intentionally bumping the minimum node version required to 6.* because we need npm 3 to avoid this problem.