Ported the URP 10.6.0 patch over to URP 12.1.4#6
Open
OBXS wants to merge 1 commit intoGPUOpen-Effects:masterfrom
Open
Ported the URP 10.6.0 patch over to URP 12.1.4#6OBXS wants to merge 1 commit intoGPUOpen-Effects:masterfrom
OBXS wants to merge 1 commit intoGPUOpen-Effects:masterfrom
Conversation
Tested working on Unity 2021.2.13, but should work on Unity 2021.2.9 ~ 13
|
@OBXS When applying this patch - I get the following error: Unity 2021.2.9f1 |
Author
|
Huh, that's interesting, I've made sure it worked when I commited it :/ |
Same issue here, did you ever get it working? |
|
Hi. i did follow the following steps without luck:
Thanks. |
|
@OBXS would you recommend ditching this version and exploring how to incorporate v2 into our URP project? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested working on Unity 2021.2.13, but should work on Unity 2021.2.9 ~ 13
Edit: I just noticed that the Sample Bias variant on SurfaceInput.hlsl will never be called because ① the Lit.shader that uses SurfaceInput.hlsl doesn't set "_AMD_FSR" as keyword (#pragma multi_compile), and it's never set to be enabled in C#. ② "amd_fsr_mipmap_bias" is never defined as a variable in the shader.
Both of these also appears to be the case for the 10.6.0 patch, was this intentional?