Replace instance level vk symbols with dynamic fetching#49
Open
EdoardoLuciani wants to merge 2 commits intoGPUOpen-Effects:masterfrom
Open
Replace instance level vk symbols with dynamic fetching#49EdoardoLuciani wants to merge 2 commits intoGPUOpen-Effects:masterfrom
EdoardoLuciani wants to merge 2 commits intoGPUOpen-Effects:masterfrom
Conversation
EdoardoLuciani
force-pushed
the
fetch-vk-functions
branch
from
29ac2f8 to
da60d59
Compare
Author
|
I rebased my branch with the latest (2.2) FSR codebase, so no more conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue I faced while integrating ffx_fsr2_api_vk_x64.lib was that the linker could not find symbols for the instance level vk functions. Since dynamic fetching is already done for device level functions, why also not do it for the instance level ones?
I tried implementing said feature trying to keep API breakage to a minimum. Indeed the only functions which got their definition changed were:
The change in order to work for the sample requires adding a GetInstance method to Device defined in Device.h which is part of the Cauldron framework. This change is not reflected in the commit due to Cauldron being a submodule.