Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to 5767
in this ^ circumstance there's a resource/distribution but because there's no distributor and the internal md object doesn't support distributor-less distributions this would return 0 resources. in my entire time of working on mdtranslator i've never had to update the internal md object so i want to avoid that as much as possible. if there's lots of documents in this scenario then i suppose we could create a dummy distributor to put the resources into but I would encourage the data provider to include one instead.
accessURL & downloadURL
the main purpose of this PR is to bring in more distributions but while i'm also bringing back mimetype calculation in harvester I decided to correct how we process
accessURLanddownloadURL. the logic for determining those fields isn't accurate. for example, an arcgis map server distribution/resource with a linkhttps://tigerweb.geo.census.gov/arcgis/rest/services/TIGERweb/tigerWMS_Current/MapServerwould be considered a downloadURL but on ckan catalog it's a web page. this noaa dataset on beta has 14 resources as downloadable files. that's incorrect. they should be web pages to visit. this PR fixes that.