Open
Conversation
- Add RoleDb constant for the database node role - Add Slurmdbd Section field to the Slurm config struct - Validate at most one db node per cluster - Reject count and managed fields on db nodes - Add slurmdbd section to fragment validation
- Add Slurmdbd and Mariadb service constants - Map RoleDb to Slurmdbd in ServiceForRole - Add GenerateSlurmdbdConf for slurmdbd.conf generation - Add hasDb parameter to GenerateSlurmConf for accounting directives - Add hasDbNode helper in resources.go - Update WriteClusterConfig to pass hasDb to GenerateSlurmConf
- Add MariadbReady probe using mysql connectivity check - Add SlurmdbdReady probe using systemctl is-active - Map Slurmdbd and Mariadb services in ForService - Include mariadb and slurmdbd probes for RoleDb in NodeProbes
- Add RoleDb to NodeRunConfigs (ShortName "db", single instance) - Add enableDbNode helper for multi-step db startup (mariadb → init accounting DB → slurmdbd) - Update EnableSlurmServices to call enableDbNode for db role
- Generate and write slurmdbd.conf when cluster has a db node - Use RunContainer for config helper when db present (needed for exec) - Fix slurmdbd.conf ownership (slurm:slurm) and mode (0600) - Add slurmdbd section fragment support
- Enable db services (mariadb → init DB → slurmdbd) before other nodes - Wait for slurmdbd readiness before starting slurmctld/slurmd - Remaining nodes (controller, workers) start concurrently as before
- Return mariadb and slurmdbd in roleServices for db role - Add mariadb and slurmdbd cases to GetNodeHealth service checks - Insert db between controller and submitter in roleSortKey
- Add db role to node roles table and validation rules - Replace planned section with implemented feature description
- Fix gofmt alignment in test files - Mark unused parameters with _ (GenerateSlurmdbdConf, test callback)
dennisklein
force-pushed
the
feat/db-role
branch
from
b99d53f to
8a47aee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
dbnode role that runs MariaDB and slurmdbd for Slurm job accounting.RoleDbconstant andSlurmdbdconfig sectionslurmdbd.confwith MariaDB connection settingsAccountingStorageType/AccountingStorageHosttoslurm.confwhen db node presentslurmdbd.confownership (slurm:slurm) and permissions (0600)MariadbReadyandSlurmdbdReadyreadiness probesslurm.slurmdbdsectionCloses #5