validate_ast: AST uniqueness validator pass#2418
Merged
Conversation
cc9fe0a to
d35665b
Compare
aleksisch
reviewed
Apr 14, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
d35665b to
7ddf367
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CodeOfPolicies::validate_ast) that checks every TypeDecl and Expression is unique (not shared) across the AST — catches accidental aliasing bugs earlyoptions validate_astTypeDecl::clone(was commented out) — safe now that uniqueness is enforcedSimNode_AstGetTypeDeclsharing TypeDecls,Variable::sourceownership (now weak ref + newloop_source), block folding source sync,apply_qmacro_functionsharing returnType, bitfield aliasSubstitution sharingAnnotation::visitTypeDeclsvirtual for validator to reach annotation-owned TypeDeclsprint_backtrace_framesandprint_current_stack_traceincrash_handler.hto eliminate duplicated stack trace code fromgc_node.cpp(also adds demangling + daScript stack walk callback to gc_break_on_id)CodeOfPolicies::validate_astandVariable::loop_sourceTest plan
dastest -- --test tests/)test_aot.exe -use-aot)das2rst.das+ Sphinx, zero warnings).dasfiles formatted🤖 Generated with Claude Code