smart_ptr: always-on tracking with linked list, remove debug macros#2420
Merged
smart_ptr: always-on tracking with linked list, remove debug macros#2420
Conversation
Remove DAS_SMART_PTR_DEBUG, DAS_SMART_PTR_TRACKER, DAS_SMART_PTR_MAGIC, DAS_SMART_PTR_ID, and DAS_ENABLE_SMART_PTR_TRACKING conditional compilation. All debug infrastructure is now always-on. Replace ref_count_ids (das_set) with intrusive doubly-linked list of all live ptr_ref_count objects. Add ref_count_magic field for type identification (Context/Program/FileAccess) without dynamic_cast. Add DumpTrackPtr() that walks the list at shutdown to report leaked pointers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DAS_SMART_PTR_DEBUG,DAS_SMART_PTR_TRACKER,DAS_SMART_PTR_MAGIC,DAS_SMART_PTR_ID, andDAS_ENABLE_SMART_PTR_TRACKINGconditional compilation — all debug infrastructure is now always-onref_count_ids(das_set<uint64_t>) with intrusive doubly-linked list of all liveptr_ref_countobjectsref_count_magicfield for type identification (Context/Program/FileAccess) withoutdynamic_castDumpTrackPtr()that walks the linked list at shutdown to report leaked pointers with type infosafeDumpType,dumpTrackingLeaks,sptrAllocations(dead tracking system)smart_ptr<DataWalker>→DataWalker?smart_ptr<ast::*>branches fromapply_to_vecTest plan
dastest -- --test tests)test_aot -use-aot).dasfiles changed — lint/format N/A🤖 Generated with Claude Code