Support pre/post install hook directories#36
Open
joshhsoj1902 wants to merge 3 commits intoGameServerManagers:mainfrom
Open
Support pre/post install hook directories#36joshhsoj1902 wants to merge 3 commits intoGameServerManagers:mainfrom
joshhsoj1902 wants to merge 3 commits intoGameServerManagers:mainfrom
Conversation
Author
|
A couple shortcomings I've noticed playing with this:
|
Author
|
GameServerManagers/LinuxGSM#4299 is likely a better option for this feature. @dgibbs64 and I had a discussion about this https://discord.com/channels/127498813903601664/1080548263977046078/1159224633376120882 I'm going to leave this PR open for now because anyone who wants to create their own Dockerfiles supporting hooks can do so by making similar changes to the most up-to-date entrypoint-user.sh and creating a file that looks like something like this: |
9487f13 to
176629c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indirectly fixes #25
This change allows users to mount a
pre-installand/orpost-installdirectory. Inside these directories users can place.shscripts which will all be executed either before or after the install step. These directories give users the flexibility to create their own derived docker images with all the customization they may need to reproduce a working custom game server.Some use cases I have:
I have an example repo setup to show how this could be used, https://github.com/joshhsoj1902/docker-linuxgsm-example