Fix: Create db directory before connecting to SQLite database#6
Open
by22Jy wants to merge 1 commit intoGamesCrafters:mainfrom
Open
Fix: Create db directory before connecting to SQLite database#6by22Jy wants to merge 1 commit intoGamesCrafters:mainfrom
by22Jy wants to merge 1 commit intoGamesCrafters:mainfrom
Conversation
- Fixes #5 - Added os.makedirs() to create db/ directory if it doesn't exist - Only creates directory when not in read-only mode (ro=False) - Prevents sqlite3.OperationalError when database file doesn't exist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue where SqliteDB fails to initialize when the
db/directory does not exist.Problem
After cloning the repository and running setup, attempting to solve a game throws:
This occurs because the
/database/db/directory is not created during project setup.Solution
os.makedirs(os.path.dirname(self.path), exist_ok=True)before connecting to the databasero=False)Changes
database/src/database/sqlite_database.py__init__method (lines 21-23)Testing
Related Issue
Fixes #5
🤖 First-time contributor! Happy to help improve this project.