Fix misaligned demand curve in tutorial 8 power plot#1
Open
patrickbryant wants to merge 4 commits intoGenXProject:mainfrom
Open
Fix misaligned demand curve in tutorial 8 power plot#1patrickbryant wants to merge 4 commits intoGenXProject:mainfrom
patrickbryant wants to merge 4 commits intoGenXProject:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In playing with tutorial 8 I noticed that demand seemed to exceed total generation in some hours of the power plot. This is due to the Demand_data.csv time series starting at row 2 while in the power.csv the timeseries starts at row 4.
The only code change is in the 6th block. I added some comments to explain the row indexing and shifted
loads_totup by 2 rows:I think it is worth fixing this for beginners like me; when I noticed the gaps between generation and demand I thought something might have gone wrong in the run resulting in unserved energy, or that I was misunderstanding something in the plotted data.
P.S. I'm a fellow at the US Department of Energy; I manage some projects which use various macro energy system models. I am finally making some time to learn to use one myself. Without a GAMS (CPLEX) license I can't effectively use ReEDS so I am very glad GenX exists! I hope to contribute from time to time as I go through the process of playing and learning. Don't hesitate to tell me if I'm doing things wrong or causing you a headache.