Skip to content

Do not let _opt_ in a sub-methods use Char. This reduces multiple-recompilations.#1937

Merged
joa-quim merged 1 commit intomasterfrom
add_opt-no-Char
Feb 26, 2026
Merged

Do not let _opt_ in a sub-methods use Char. This reduces multiple-recompilations.#1937
joa-quim merged 1 commit intomasterfrom
add_opt-no-Char

Conversation

@joa-quim
Copy link
Member

No description provided.

@joa-quim joa-quim merged commit 2a272b9 into master Feb 26, 2026
7 of 10 checks passed
@joa-quim joa-quim deleted the add_opt-no-Char branch February 26, 2026 21:47
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.21%. Comparing base (fa9518c) to head (7b6aa7d).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/common_options.jl 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1937      +/-   ##
==========================================
- Coverage   85.22%   85.21%   -0.01%     
==========================================
  Files         188      187       -1     
  Lines       27919    27554     -365     
==========================================
- Hits        23794    23481     -313     
+ Misses       4125     4073      -52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants