Skip to content

add trogworld page#1

Merged
GenesisFR merged 2 commits intoGenesisFR:masterfrom
soyuka:patch-1
Nov 29, 2020
Merged

add trogworld page#1
GenesisFR merged 2 commits intoGenesisFR:masterfrom
soyuka:patch-1

Conversation

@soyuka
Copy link
Copy Markdown
Contributor

@soyuka soyuka commented Nov 19, 2020

No description provided.

Copy link
Copy Markdown
Owner

@GenesisFR GenesisFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "DS mods" between parenthesis, place it one line above as the links are sorted in alphabetical order and add yourself in the credits.

@soyuka
Copy link
Copy Markdown
Contributor Author

soyuka commented Nov 19, 2020

Done.

I'm playing this game on linux via wine, could I contribute on a HowTo wine installation?

@GenesisFR
Copy link
Copy Markdown
Owner

GenesisFR commented Nov 19, 2020

Sure, go ahead in another pull request, though keep in mind someone has already made a similar installation guide for DS2 GenesisFR/DS2TroubleshootingGuide#1. I added the export to REG feature because of it but I've never heard from him since so I have no clue if it even works properly on Linux, could you test that out if you have time?

Also, I'll end up replicating this pull request instead of merging it as I have a strict nomenclature regarding commit syntax (you can check my past commits for examples) I learned at my first job:

+ = addition
- = modification
* = fix

Thanks for your contribution. How would you like to be credited?

@soyuka
Copy link
Copy Markdown
Contributor Author

soyuka commented Nov 19, 2020

You could use the squash (instead of merge) button and change the commit yourself

The RegEdit thing is to make the system believe an older version of the game is installed. A similar thing helps to install dungeon siege editor on a steam verison of the game: https://steamcommunity.com/app/39190/discussions/0/882959527674476138/

@GenesisFR GenesisFR merged commit 7b5e679 into GenesisFR:master Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants