fix: undefined process in stream client#625
Open
helene-hilaire wants to merge 1 commit intoGetStream:mainfrom
Open
fix: undefined process in stream client#625helene-hilaire wants to merge 1 commit intoGetStream:mainfrom
helene-hilaire wants to merge 1 commit intoGetStream:mainfrom
Conversation
helene-hilaire
requested review from
JimmyPettersson85,
MartinCupela,
arnautov-anton and
itsmeadi
as code owners
itsmeadi
approved these changes
May 12, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the process object was accessed unsafely by changing the check to use "typeof process" to ensure it is defined.
- Replaced a direct undefined check on process with a typeof check to prevent potential runtime errors in non-Node environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #570