Delete field from target when not in source#10
Merged
Conversation
Collaborator
Author
|
Added the same feature that was added to the |
Member
|
Do we need the deleteMissing flag? I understand that it preserves the existing behavior but Im not sure that's good thing - I cant think of a use case where you would want the last stale value left in the target when the field gets deleted in the source let alone making this the default behavior. I believe this warrants a breaking change - and and major version number increase |
Member
|
Want to update the version no. is this PR? |
Collaborator
Author
|
Yeah sure. I was going to do it in #4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From issue #8, the new feature deletes a field in the target collection docs, the deleteMissing flag defaults to false. Field needs to be in the attribute mapping to be removed for example:
if the after snapshot is (master):
The
foreignDetail2will be deleted from the target snapshot asmasterDetail2is not there and maps toforeignDetail2