Handle circular oneOf with discriminator and allOf in OpenAPI schemas#4070
Draft
nolannbiron wants to merge 1 commit intomainfrom
Draft
Handle circular oneOf with discriminator and allOf in OpenAPI schemas#4070nolannbiron wants to merge 1 commit intomainfrom
nolannbiron wants to merge 1 commit intomainfrom
Conversation
Detect when allOf entries reference an ancestor schema (e.g. Dog allOf: [Pet, ...]) and break the cycle by stripping polymorphic fields before merging. Also default schema titles to component names before dereference so they propagate through $ref resolution.
|
Contributor
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect when allOf entries reference an ancestor schema (e.g. Dog allOf: [Pet, ...]) and break the cycle by stripping polymorphic fields before merging. Also default schema titles to component names before dereference so they propagate through $ref resolution.