Show Github stargazer counts in the timeline#22
Open
jorgeberrex wants to merge 1 commit intoGoldenStack:mainfrom
Open
Show Github stargazer counts in the timeline#22jorgeberrex wants to merge 1 commit intoGoldenStack:mainfrom
jorgeberrex wants to merge 1 commit intoGoldenStack:mainfrom
Conversation
Owner
|
Seems cool - unsure about merging this since it (1) pushes over the timeline a bit, which looks slightly weird, (2) adds a bunch of visible delay as things load, and (3) locks the project into only GitHub projects (although I guess this was probably going to be true anyway, and we can add support for other sites as we need them). |
|
Small suggestion, maybe making it be a card upon hovering the name? Would fix all issues since:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a simple change to query the Github stargazer count for each listed repository using the public GitHub API.