Skip to content

Fix native helm ingress host overrides#138

Merged
vigneshrajsb merged 8 commits intomainfrom
fix/native-helm-ingress-host
Mar 19, 2026
Merged

Fix native helm ingress host overrides#138
vigneshrajsb merged 8 commits intomainfrom
fix/native-helm-ingress-host

Conversation

@vigneshrajsb
Copy link
Contributor

@vigneshrajsb vigneshrajsb commented Mar 18, 2026

Summary

  • restore ingress host, alt host, whitelist, KEDA ingress, and gRPC mapping Helm overrides in the native org-chart deploy path
  • fix native Helm env var key escaping so direct Helm deploys preserve keys like DB_HOST instead of emitting DB__HOST
  • remove the unused ${resourceType}.version override from both legacy/codefresh Helm and native Helm org-chart deploy paths
  • add minimal native Helm ecr-auth init-container logging so OCI auth progress is visible without exposing secrets
  • archive non-Helm native deploy (kubernetes-apply) job logs to object storage, matching the existing native build and native Helm archival behavior
  • add regression coverage for the native Helm and deployment-manager changes

Validation

  • pnpm test -- src/server/lib/nativeHelm/tests/helm.test.ts
  • pnpm test -- src/server/lib/nativeHelm/tests/registryAuth.test.ts src/server/lib/nativeHelm/tests/helm.test.ts
  • pnpm test -- src/server/lib/tests/deploymentManager.test.ts
  • pnpm test

Debug Context

  • compared preview envs for build UUIDs small-breeze-095556 and super-bonus-027636 to confirm the ingress host gap on native Helm
  • compared native super-wave-503124 with codefresh tight-field-825984 to confirm gRPC mapping parity and identify the env-var key escaping mismatch
  • verified live MinIO archived logs for env-super-bonus-027636 native Helm job lifecycle-docs-super-bonus-027636-deploy-tgwk-479991a, confirming init-container logs are present in the archive
  • verified the non-Helm archival gap live in env-crimson-tooth-697165, where completed kubernetes-apply deploy jobs existed but no deploy log objects were present under env-crimson-tooth-697165/deploy/

Testing

  • tested the native Helm ingress fix with the alpha image flow and confirmed ingress behavior now matches the codefresh path
  • verified the native Helm archived log object contains clone-repo, ecr-auth, and helm-deploy sections for a live deploy job

@vigneshrajsb vigneshrajsb requested a review from a team as a code owner March 18, 2026 22:06
@vigneshrajsb vigneshrajsb force-pushed the fix/native-helm-ingress-host branch from aabe369 to cd9349b Compare March 18, 2026 22:52
@vigneshrajsb vigneshrajsb force-pushed the fix/native-helm-ingress-host branch from 3c5dd65 to 9b282d0 Compare March 19, 2026 17:54
@vigneshrajsb vigneshrajsb merged commit 1ac5996 into main Mar 19, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants