Skip to content

Caching icons with the service worker for offline use case #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dp-Goog merged 2 commits into from
Feb 10, 2026
Merged

Caching icons with the service worker for offline use case #930

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
080979c
Caching icons to test offline use case
akyereboah Feb 9, 2026
a129d3b
Update cache version
akyereboah Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions pwa-testing/manifest-localization-test/service-worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const CACHE_NAME = 'manifest-localization-test-v1';
const CACHE_NAME = 'manifest-localization-test-v2';
const MANIFEST_URL = './manifest.json';

// Files to cache
Expand All @@ -7,7 +7,15 @@ const urlsToCache = [
'./index.html',
'./manifest.json',
'./style.css',
'./main.js'
'./main.js',
'./icons/icon-128.png',
'./icons/icon-192.png',
'./icons/icon-256.png',
'./icons/icon-512.png',
'./icons/localized_icons/ar/icon-128.png',
'./icons/localized_icons/ar/icon-256.png',
'./icons/localized_icons/de/icon-128.png',
'./icons/localized_icons/de/icon-256.png'
];

// Install event - cache files
Expand Down