Skip to content

chore(deps): replace dependency eslint-plugin-node with eslint-plugin-n 14.0.0 #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate-bot wants to merge 1 commit into
base: v1
Choose a base branch
from
Open

chore(deps): replace dependency eslint-plugin-node with eslint-plugin-n 14.0.0 #1443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 47 additions & 12 deletions nodejs/nodejs-cloud-run-hello-world/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion nodejs/nodejs-cloud-run-hello-world/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"devDependencies": {
"eslint": "8.54.0",
"eslint-config-prettier": "8.10.0",
"eslint-plugin-node": "11.1.0",
"eslint-plugin-n": "14.0.0",
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

With the replacement of eslint-plugin-node with eslint-plugin-n, the ESLint configuration in nodejs/nodejs-cloud-run-hello-world/.eslintrc.yml also needs to be updated. The current configuration still refers to the old node plugin, which means the new linting rules will not be applied.

Please update extends and plugins in .eslintrc.yml to use n instead of node:

--- a/nodejs/nodejs-cloud-run-hello-world/.eslintrc.yml
+++ b/nodejs/nodejs-cloud-run-hello-world/.eslintrc.yml
@@ -2,7 +2,7 @@
 extends:
   - 'eslint:recommended'
-  - 'plugin:node/recommended'
+  - 'plugin:n/recommended'
   - prettier
 plugins:
-  - node
+  - n
   - prettier

"eslint-plugin-prettier": "4.2.1",
"eslint-plugin-promise": "6.1.1",
"gaxios": "5.1.3",
Expand Down