fix: use CSQL_PROXY_AUTO_IAM_AUTHN instead of params to enable auto-iam-authn#722
Closed
mruoss wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Closed
fix: use CSQL_PROXY_AUTO_IAM_AUTHN instead of params to enable auto-iam-authn#722mruoss wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
mruoss wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
mruoss
force-pushed
the
fix-auto-iam-authn
branch
from
651a6d7 to
19fd8ef
Compare
mruoss
force-pushed
the
fix-auto-iam-authn
branch
from
19fd8ef to
89c3e9e
Compare
mruoss
changed the title
Author
|
Hey @hessjcg |
Author
|
Is this repo still maintained? Maybe @apeabody would know? |
Collaborator
|
Thank you for the change, but I think the best way to fix the issue is in the Auth Proxy code. See GoogleCloudPlatform/cloud-sql-proxy#2542 I created a draft PR with the fix. I'm still working on it. GoogleCloudPlatform/cloud-sql-proxy#2543 Feel free to help me test this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #719
Appropriate changes to README are included in PR