fix: unbind manual affinity keys after terminal calls#232
Merged
rahul2393 merged 2 commits intoGoogleCloudPlatform:masterfrom Mar 20, 2026
Merged
fix: unbind manual affinity keys after terminal calls#232rahul2393 merged 2 commits intoGoogleCloudPlatform:masterfrom
rahul2393 merged 2 commits intoGoogleCloudPlatform:masterfrom
Conversation
sakthivelmanii
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change prevents manual affinity keys from accumulating in grpc-gcp’s affinity map for terminal transaction RPCs.
What changed
UNBIND_AFFINITY_KEYtoGcpManagedChannelcall optionsSimpleGcpClientCallto unbind the manual affinity key on successful completion when that option is setSimpleGcpClientCallto always unbind the manual affinity key on cancelWhy
Java Spanner dynamic channel pooling already configures affinity cleanup with:
That cleanup is time-based, so terminal RPCs such as commit or rollback could still leave manual affinity keys in the map until the cleanup task ran. This change makes cleanup immediate for explicit terminal flows, preventing unnecessary growth of the affinity map and reducing stale channel stickiness for abandoned or completed transactions.
Impact