Skip to content

fix(deps): update dependency @google-cloud/firestore to v6 [security]#657

Open
renovate-bot wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
renovate-bot:renovate/npm-google-cloud-firestore-vulnerability
Open

fix(deps): update dependency @google-cloud/firestore to v6 [security]#657
renovate-bot wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
renovate-bot:renovate/npm-google-cloud-firestore-vulnerability

Conversation

@renovate-bot
Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
@google-cloud/firestore ^5.0.0^6.2.0 age confidence

GitHub Vulnerability Alerts

CVE-2023-6460

A potential logging of the firestore key via logging within nodejs-firestore exists - Developers who were logging objects through this._settings would be logging the firestore key as well potentially exposing it to anyone with logs read access. We recommend upgrading to version 6.1.0 to avoid this issue


Release Notes

googleapis/nodejs-firestore (@​google-cloud/firestore)

v6.2.0

Compare Source

Features
Bug Fixes
  • Minify proto JSON files (#​1771) (6393fe7)
  • Remove hack in update.sh, and replace with existing pattern for protobuf dependencies. (#​1769) (6ba6751)

v6.0.0

Compare Source

⚠ BREAKING CHANGES
  • update library to use Node 12 (#​1725)
Features
Bug Fixes
Build System
5.0.2 (2022-01-07)
Bug Fixes
5.0.1 (2021-12-02)
Bug Fixes

v5.0.2

Compare Source


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@dpebot
Copy link
Copy Markdown
Collaborator

dpebot commented Mar 30, 2026

/gcbrun

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @google-cloud/firestore dependency from version 5.0.0 to 6.2.0 across several modules. Feedback indicates that for the sessions module, the @google-cloud/connect-firestore package must also be upgraded to version 3.0.0 to ensure compatibility with the new Firestore version and avoid potential runtime issues.

Comment on lines 13 to +14
"@google-cloud/connect-firestore": "^2.0.0",
"@google-cloud/firestore": "^5.0.0",
"@google-cloud/firestore": "^6.2.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upgrading @google-cloud/firestore to v6 (a major version bump) requires a corresponding update to @google-cloud/connect-firestore to version ^3.0.0. The current version (^2.0.0) is incompatible with Firestore v6, which will lead to peer dependency conflicts and potential runtime errors during session management.

Note: Upgrading to connect-firestore v3 also requires a code change in sessions/index.js: the dataset property in the FirestoreStore constructor should be renamed to firestore to align with the updated API.

Suggested change
"@google-cloud/connect-firestore": "^2.0.0",
"@google-cloud/firestore": "^5.0.0",
"@google-cloud/firestore": "^6.2.0",
"@google-cloud/connect-firestore": "^3.0.0",
"@google-cloud/firestore": "^6.2.0",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants