Skip to content

fix(deps): update dependency multer to v2 [security] #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(deps): update dependency multer to v2 [security] #658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bookshelf/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"@google-cloud/storage": "^6.0.0",
"body-parser": "^1.18.3",
"express": "^4.16.4",
"multer": "^1.4.1",
"multer": "^2.1.1",
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upgrading to multer v2.x is a major version bump that introduces breaking changes. The current implementation in bookshelf/lib/images.js (line 77) uses Multer.MemoryStorage, which is incorrect for both v1 and v2. It should be updated to Multer.memoryStorage() (a function call) to correctly initialize the memory storage engine. In v2, passing the class/constructor instead of an instance will cause the middleware to fail during file processing.

Additionally, verify that the deployment environment supports the new minimum Node.js version requirement (10.16.0) mentioned in the release notes.

"pug": "^3.0.0"
},
"devDependencies": {
Expand Down