fix(firestore): Update firestore samples for python to use recursive delete

[XrossFox]

 b/470275866
 Modified samples for Firestore Client and Asyn Firestore Client.

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

• I have followed Sample Guidelines from AUTHORING_GUIDE.MD
• README is updated to include all relevant information
• Tests pass: nox -s py-3.9 (see Test Environment Setup)
• Lint pass: nox -s lint (see Test Environment Setup)
• These samples need a new API enabled in testing projects to pass (let us know which ones)
• These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
• This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
• This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
• Please merge this PR for me once it is approved

[gemini-code-assist]

Summary of Changes

Hello @XrossFox, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the Firestore Python samples for collection deletion. Instead of implementing a custom, potentially error-prone iterative deletion process, the samples now leverage the built-in recursive_delete functionality provided by the Firestore client library. This change significantly simplifies the code, improves readability, and ensures that the deletion process is handled optimally by the underlying library.

Highlights

• Simplified Collection Deletion: The manual, iterative logic for deleting Firestore collections has been replaced with the more efficient and concise db.recursive_delete() method.
• Asynchronous Client Update: The firestore/cloud-async-client/snippets.py sample now uses await db.recursive_delete() for asynchronous collection deletion.
• Synchronous Client Update: The firestore/cloud-client/snippets.py sample now uses db.recursive_delete() for synchronous collection deletion.

Changelog

• firestore/cloud-async-client/snippets.py
  • Replaced custom asynchronous collection deletion loop with await db.recursive_delete(coll_ref).
  • Removed the batch_size parameter from the delete_collection function signature.
• firestore/cloud-client/snippets.py
  • Replaced custom synchronous collection deletion loop with db.recursive_delete(coll_ref).
  • Removed the batch_size parameter from the delete_collection function signature.
  • Added a print statement to indicate recursive deletion.

Activity

• The pull request was created by XrossFox.
• The PR title indicates a fix for Firestore Python samples to use recursive delete.
• The description confirms modification of samples for both Firestore Client and Async Firestore Client, noting they do not use Nox.
• The PR aims to fix an issue, indicated by 'Fixes #'.
• The author has included a standard checklist for sample guidelines, testing, linting, API enablement, environment variables, CODEOWNERS, and Blunderbuss updates.
• The author has requested that the PR be merged once approved.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the Firestore samples for both synchronous and asynchronous clients to use the recursive_delete method for deleting collections. This is a great improvement as it simplifies the code and uses the recommended approach. I have one suggestion for the asynchronous sample to add a print statement for consistency with the synchronous sample, which will improve the user experience when running the snippet.