stop exempting VPN app from leak blocking#315
Open
liamsmith827 wants to merge 2 commits intoGrapheneOS:16-qpr2from
Open
stop exempting VPN app from leak blocking#315liamsmith827 wants to merge 2 commits intoGrapheneOS:16-qpr2from
liamsmith827 wants to merge 2 commits intoGrapheneOS:16-qpr2from
Conversation
Android provides VPN apps the capability to protect sockets that should bypass the tunnel and leak blocking protection. It is then expected that any socket that is not protected should not get a bypass. This is clearly documented and easy for VPN app developers to implement. However, Android decided that some VPN apps might forget to protect their sockets and added an exemption that allows the VPN app to bypass leak blocking protection, even for unprotected sockets. As a result of this exemption, the VPN app has no way to force traffic through the tunnel, so anything it wishes to send through the tunnel is subject to being leaked. This change removes the exemption. If a VPN app breaks due to this change it is, by definition, a broken app that was being saved by a workaround. The developers should fix it. Disabling leak blocking for that app will allow it to work again. If the app can't get protected sockets right, it probably isn't preventing leaks in the first place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android provides VPN apps the capability to protect sockets that should bypass
the tunnel and leak blocking protection. It is then expected that any socket
that is not protected should not get a bypass. This is clearly documented and
easy for VPN app developers to implement. However, Android decided that some VPN
apps might forget to protect their sockets and added an exemption that allows
the VPN app to bypass leak blocking protection, even for unprotected sockets. As
a result of this exemption, the VPN app has no way to force traffic through the
tunnel, so anything it wishes to send through the tunnel is subject to being
leaked.
This change removes the exemption. If a VPN app breaks due to this change it is,
by definition, a broken app that was being saved by a workaround. The developers
should fix it. Disabling leak blocking for that app will allow it to work again.
If the app can't get protected sockets right, it probably isn't preventing leaks
in the first place.
GrapheneOS/platform_packages_modules_NetworkStack#17
GrapheneOS/platform_packages_modules_Connectivity#38
GrapheneOS/os-issue-tracker#5273