Skip to content

Introduce development Nix binary cache#3911

Open
timon-schelling wants to merge 4 commits intomasterfrom
dev-nix-cache
Open

Introduce development Nix binary cache#3911
timon-schelling wants to merge 4 commits intomasterfrom
dev-nix-cache

Conversation

@timon-schelling
Copy link
Member

@timon-schelling timon-schelling commented Mar 18, 2026

@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@timon-schelling
Copy link
Member Author

timon-schelling commented Mar 18, 2026

!build desktop:linux (Run ID 23256065185)

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/build.yml">

<violation number="1" location=".github/workflows/build.yml:581">
P1: The cache-push step now ignores `push_to_nix_cache` and always attempts cachix auth/push, which can break non-push or opt-out runs when cache secrets are unavailable.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 3 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/nix.yml">

<violation number="1" location=".github/workflows/nix.yml:23">
P1: Pin this third-party action to an immutable commit SHA instead of `@main` to prevent supply-chain drift.</violation>
</file>

<file name=".github/workflows/build.yml">

<violation number="1" location=".github/workflows/build.yml:574">
P1: Do not trust the dev Cachix key/cache in the shared Linux workflow setup; it allows dev-signed substitutes to be consumed (and potentially promoted) during production cache publishing.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

ref: ${{ inputs.checkout_ref || '' }}

- name: ❄ Install Nix
uses: DeterminateSystems/nix-installer-action@main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Pin this third-party action to an immutable commit SHA instead of @main to prevent supply-chain drift.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/nix.yml, line 23:

<comment>Pin this third-party action to an immutable commit SHA instead of `@main` to prevent supply-chain drift.</comment>

<file context>
@@ -0,0 +1,37 @@
+          ref: ${{ inputs.checkout_ref || '' }}
+
+      - name: ❄ Install Nix
+        uses: DeterminateSystems/nix-installer-action@main
+        with:
+          extra-conf: |
</file context>

@github-actions
Copy link

github-actions bot commented Mar 18, 2026

📦 Linux Build Complete for e30a995
Download binary
Download Flatpak

@timon-schelling
Copy link
Member Author

timon-schelling commented Mar 18, 2026

!build desktop:linux (Run ID 23259360770)

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/nix.yml">

<violation number="1" location=".github/workflows/nix.yml:40">
P1: `CACHE_URL` is unset here, so `set -u` makes the cache-check step fail before `curl` runs.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@github-actions
Copy link

github-actions bot commented Mar 18, 2026

📦 Linux Build Complete for 1d84d06
Download binary
Download Flatpak

@timon-schelling timon-schelling changed the title Desktop: Introduce development Nix binary cache Introduce development Nix binary cache Mar 18, 2026
@Keavon Keavon force-pushed the master branch 4 times, most recently from 9b97ab7 to 2e842cb Compare March 19, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant