Show node display name in properties panel if set#3930
Show node display name in properties panel if set#3930timon-schelling wants to merge 1 commit intomasterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the user experience within the node graph editor by prioritizing the display of user-assigned node names in the properties panel. This change directly addresses an issue where the internal implementation name was shown, which could be less intuitive for users, making the panel more user-friendly and informative. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request changes the title displayed in the node properties panel. It now uses the node's display name, which can be set by the user, instead of its implementation name. If no display name is set, it falls back to the implementation name, so the behavior for nodes without custom names is unchanged. This is done by calling the display_name method instead of implementation_name.
closes #2461
Not sure we want to do it this way forever, but it's at least an improvement in the sort term.