Fix BigInt serialization error in lookup table test flow#25396
Merged
danotorrey merged 1 commit intomasterfrom Mar 20, 2026
Merged
Fix BigInt serialization error in lookup table test flow#25396danotorrey merged 1 commit intomasterfrom
danotorrey merged 1 commit intomasterfrom
Conversation
PR #23432 introduced json-with-bigint for deserializing large numbers as BigInt, but DataAdapter.tsx and test-lookup.tsx still used native JSON.stringify which cannot serialize BigInt values. This causes a TypeError when displaying lookup results containing large AD timestamps like accountExpires or pwdLastSet. Replace JSON.stringify with JSONStringify from json-with-bigint in both lookup table test/preview pages. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ryan-carroll-graylog
approved these changes
Mar 20, 2026
Contributor
ryan-carroll-graylog
left a comment
ryan-carroll-graylog
left a comment
There was a problem hiding this comment.
Looks good and tests successfully! Nice job on the quick fix/troubleshooting Dan!
kingzacko1
approved these changes
Mar 20, 2026
danotorrey
changed the title
Contributor
Author
|
FYI @dennisoelkers this came up with some testing of the latest field expansion enhancements for the AD adapter. Let me know if you see any issues here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataAdapter.tsxandtest-lookup.tsxused nativeJSON.stringifyto display lookup results, which throwsTypeError: Do not know how to serialize a BigIntBigInt. #23432 changedFetchProvider.tsto parse API responses withJSONParsefromjson-with-bigint(large numbers becomeBigInt), but these two files were not update)accountExpires: 9223372036854775807(Long.MAX_VALUE) which exceedNumber.MAX_SAFE_INTEGERttlfield for any adapter was also affected.JSON.stringifywithJSONStringifyfromjson-with-bigintin both filesError when looking up adapter cal
Appears to have been introduced when #23432 was merged.
/nocl fixed unreleased error
Test plan
test-lookup.tsx) also handles BigInt valuesnpx jest -- 'components/lookup-tables/DataAdapter.test.tsx'— all tests pass🤖 Generated with Claude Code