Added support for Fluidlogged API for some blocks#2815
Open
Shazuli wants to merge 2 commits intoGregTechCEu:masterfrom
Open
Added support for Fluidlogged API for some blocks#2815Shazuli wants to merge 2 commits intoGregTechCEu:masterfrom
Shazuli wants to merge 2 commits intoGregTechCEu:masterfrom
Conversation
Contributor
|
would this break compatibility with legacy 2.x version of fluidlogged api? |
Author
With "cf" you mean CurseForge right? Looks like And the license for Fluidlogged API should allow for compatibility with GTCEu if I read it right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Added support for Fluidlogged API (Modrint) for Frames and Pipes.
Additional Information
Potential Compatibility Issues
I had to change method
isInCreativeTabfromprotectedtopublicingregtech.api.items.metaitem.MetaItem.java, otherwise the project didn't compile. I can't explain why.