Remove Deprecated Use of FetchContent_Populate#1825
Open
fthaler wants to merge 3 commits intoGridTools:masterfrom
Open
Remove Deprecated Use of FetchContent_Populate#1825fthaler wants to merge 3 commits intoGridTools:masterfrom
fthaler wants to merge 3 commits intoGridTools:masterfrom
Conversation
Collaborator
|
Hi there, this is jenkins continuous integration... |
fthaler
commented
Feb 18, 2026
| FetchContent_GetProperties(pybind11) | ||
| if(NOT pybind11_POPULATED) | ||
| FetchContent_Populate(pybind11) | ||
| set(PYTHON_EXECUTABLE ${Python_EXECUTABLE}) |
Contributor
Author
There was a problem hiding this comment.
I don’t know why this line existed, is it needed for something I’ve overlooked?
There was a problem hiding this comment.
Pull request overview
This PR modernizes the project’s FetchContent usage by replacing the deprecated FetchContent_Populate() flow with FetchContent_MakeAvailable(), aligning both build logic and documentation with current CMake practices.
Changes:
- Update the Python bindings regression test CMake to use
FetchContent_MakeAvailable(pybind11). - Update the introduction manual’s FetchContent example to use
FetchContent_MakeAvailable(GridTools).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/regression/py_bindings/CMakeLists.txt |
Switch pybind11 dependency setup to FetchContent_MakeAvailable for non-deprecated FetchContent integration. |
docs_src/manuals/introduction/introduction.rst |
Update FetchContent documentation snippet to use FetchContent_MakeAvailable instead of FetchContent_Populate. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.