Skip some parallel example tests for small MPIEXEC_MAX_NUMPROCS values#6224
Merged
lrknox merged 1 commit intoHDFGroup:developfrom Feb 23, 2026
Merged
Skip some parallel example tests for small MPIEXEC_MAX_NUMPROCS values#6224lrknox merged 1 commit intoHDFGroup:developfrom
lrknox merged 1 commit intoHDFGroup:developfrom
Conversation
jhendersonHDF
requested review from
bmribler,
brtnfld,
derobins,
fortnern,
glennsong09,
lrknox,
mattjala,
qkoziol and
vchoi-hdfgroup
as code owners
brtnfld
reviewed
Feb 18, 2026
brtnfld
approved these changes
Feb 18, 2026
lrknox
approved these changes
Feb 23, 2026
github-project-automation
Bot
moved this from In progress
to Done
in HDF5 - TRIAGE & TRACK
lrknox
pushed a commit
to lrknox/hdf5
that referenced
this pull request
Feb 25, 2026
lrknox
added a commit
that referenced
this pull request
Feb 25, 2026
* Skip some parallel example tests for small MPIEXEC_MAX_NUMPROCS values (#6224) * chore: fix grammar (#6227) * Split static targets into separate optional target [UPDATED] (#6216) Build-tree exports can't diverge from install-tree exports — the export(EXPORT ...) reads directly from the install export sets. No manual list to keep in sync. Removed 3 global variables (HDF5_STATIC_LIBRARIES_TO_EXPORT, HDF5_JAVA_LIBRARIES_TO_EXPORT, HDF5_UTILS_TO_EXPORT) and their ~21 set_global_variable calls across tool/utility files. Fixed the static-only build bug in the PR where the base export set was guarded by BUILD_SHARED_LIBS, breaking tools export. Removed redundant utils in export files — the PR was dumping tools into all three build-tree export files (java, static, shared). Now they correctly appear only in the base export. * Apply filters to variable-length data (#6178) Closes can_apply and set_local filter callbacks skipped for H5T_VARIABLE dtypes #5942. A more detailed explanation of the rationale for this PR is in the linked issue. Mandatory filters can be now applied to variable-length data. This notably includes h5py object strings and NpyStrings. Optional filters applied to variable-length data no longer skip can_apply and set_local, only to jump directly to filter. This fixes hdf5_blosc and HDF5_Blosc2, which rely on set_local. Note that all filters which have neither can_apply nor set_local have always worked fine with vlen data, as long as they were tagged as optional. Notable examples are deflate, lzf, bzip2 (from hdf5plugin), and lz4 (also from hdf5plugin). Lossy filters, such as scale-offset, are and remain untested and most likely broken, as I expect them to treat the vlen metadata as numbers and corrupt it. The right place to ensure proper behaviour is their can_apply function, which however is broken (filters: can_apply does nothing for optional filters #6161).
brtnfld
pushed a commit
to brtnfld/hdf5
that referenced
this pull request
Mar 18, 2026
brtnfld
pushed a commit
to brtnfld/hdf5
that referenced
this pull request
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Modify
ADD_GREP_TESTmacro to skip tests ifMPIEXEC_MAX_NUMPROCSis insufficient inH5PAR/CMakeLists.txtandH5PAR/FORTRAN/CMakeLists.txt.ADD_GREP_TESTmacro inH5PAR/CMakeLists.txtandH5PAR/FORTRAN/CMakeLists.txtto skip tests ifMPIEXEC_MAX_NUMPROCSis less than requirednumprocs.mumprocstonumprocsin both files.This description was created by
for a32950f. You can customize this summary. It will automatically update as commits are pushed.