Draft
Conversation
blu-dev
added
engine
|
Download the artifacts for this pull request: |
Contributor
|
Videos are down |
SuddyN
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assets:
parry-layout-assets.zip
General Summary
This pull requests brings back light shielding, a mechanic not seen in any Smash iteration (or platform fighter, to my knowledge) since Melee. Formulas for shield damage, shield pushback, attacker rebound, and shield stun have all been inspired by Melee but adapted to HDR.
Please understand that I am aware this is a controversial change, I make this PR because this has been my one singular passionate goal for Ultimate modding since February, 2021. I have been through iteration hell trying to get this working, and more importantly, getting it working online.
If this PR never gets merged that's alright with me, I will be content with having implemented. I just wanted to showcase it, and garner feedback and see how people feel. It would make me very happy if it got merged, but I do not expect it.
Detailed Changes
Trigger Thresholds
Due to some code mixups, this change actually also applies to the parry pull request (#1535).
In previous versions of HDR, Gamecube controller triggers get registered as digital button presses starting at 0.33 (this is not exactly 1/3 of the way down, this is after the Switch's HID driver's deadzones).
Now, analog values start getting registered between 0.1 and end at 0.8. Anything below 0.1 gets mapped to 0.0, and anything above 0.8 gets mapped to 1.0. Values between 0.1 and 0.8 get linearly interpolated between 0 and 1.0
This makes Gamecube triggers register earlier than what might be expected, and there might need to be additional logic performed on these to detect releases so that gamefeel continues to feel good. Thank you for patience!
Shield Scaling
The maximum light shield has a radius of 2x the full hard shield of a character. Since this value is literally impossible to reach (would require an analog value of 0.0), the maximum radius is a little lower than that.
Formulas
Where
Ais the analog value of the shield, andsetoff_mulis a per-move value:attack_power * 1.4attack_power * (1.4 + 0.2 * (1.0 - A))attack_power * setoff_mul * 0.55attack_power * setoff_mul * ((1.0 - A) * 0.65 + 0.55 / 1.5) * 1.5attack_power * 0.051attack_power * (0.195 * (1.0 - A) + 0.051)attack_power * 0.04attack_power * 0.04 * A * 0.1Some of these formulas may be implemented incorrectly, it was very difficult to locate where to implement them, so I may change these over time.
Videos:
https://streamable.com/19671f
https://streamable.com/9lq0ou