优化 Java 下载 by Glavo · Pull Request #5859 · HMCL-dev/HMCL

Glavo · 2026-03-26T12:59:35Z

清理代码；
先将文件下载至临时文件夹，下载完毕后再移动至目标目录。

Copilot

Pull request overview

此 PR 旨在优化 Mojang Java 运行时下载流程：清理数据结构代码，并将运行时文件先下载到临时目录，完成校验后再整体落盘到目标安装目录，以减少半成品文件污染目标目录的风险。

Changes:

将 MojangJavaDownloads 及其内部数据结构改为 record，并使用 @JsonSerializable 标注。
MojangJavaDownloadTask 增加临时目录参数，下载/解压输出改写入 tempDir，并在 postExecute() 中校验后再迁移到 target。
HMCLJavaRepository 调整为创建并传入 .tmp 临时目录，并适配 record 访问方式。

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
HMCLCore/src/main/java/org/jackhuang/hmcl/download/java/mojang/MojangJavaDownloads.java	结构体清理：从普通类迁移到 `record`，简化字段/访问器并保持 Gson 适配器逻辑。
HMCLCore/src/main/java/org/jackhuang/hmcl/download/java/mojang/MojangJavaDownloadTask.java	下载落盘策略调整：新增 `tempDir`，下载/解压后做 SHA-1 校验，再迁移到 `target`。
HMCL/src/main/java/org/jackhuang/hmcl/java/HMCLJavaRepository.java	调整 Java 下载任务构造参数：为每个平台/组件提供固定临时目录并适配 `record` API。

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

HMCLCore/src/main/java/org/jackhuang/hmcl/download/java/mojang/MojangJavaDownloadTask.java

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

HMCLCore/src/main/java/org/jackhuang/hmcl/download/java/mojang/MojangJavaDownloadTask.java

Copilot · 2026-03-26T13:23:21Z

HMCLCore/src/main/java/org/jackhuang/hmcl/download/java/mojang/MojangJavaDownloadTask.java

+                DownloadInfo raw = remoteFile.getDownloads().get("raw");
+                if (raw != null && raw.getSha1() != null) {
+                    Path dest = tempDir.resolve(entry.getKey());
+                    String actual = DigestUtils.digestToString("SHA-1", dest);


doPostExecute() returns true, so postExecute() will run even when dependency downloads fail (the task framework passes a non-null dependenciesException but still invokes postExecute). Currently postExecute() will verify/checksum, clean target, and move/copy tempDir regardless, which can wipe a working Java runtime after a failed/partial download. Add an early guard like if (!isDependenciesSucceeded()) return; (or throw) before any filesystem mutations.

Copilot · 2026-03-26T13:23:21Z

HMCLCore/src/main/java/org/jackhuang/hmcl/download/java/mojang/MojangJavaDownloadTask.java

-            } else if (entry.getValue() instanceof MojangJavaRemoteFiles.RemoteLink) {
-                MojangJavaRemoteFiles.RemoteLink link = ((MojangJavaRemoteFiles.RemoteLink) entry.getValue());
+            } else if (entry.getValue() instanceof MojangJavaRemoteFiles.RemoteLink link) {
                Files.deleteIfExists(dest);


Creating RemoteLink entries doesn’t ensure the parent directory exists. Since javaDownloadsTask.getResult().getFiles() is a Map with no guaranteed iteration order, a link may be processed before its parent RemoteDirectory, causing Files.createSymbolicLink(dest, ...) to fail with NoSuchFileException. Create dest.getParent() directories before creating the symlink (when parent is non-null).

Suggested change

Files.deleteIfExists(dest);

Files.deleteIfExists(dest);

Path parent = dest.getParent();

if (parent != null) {

Files.createDirectories(parent);

}

Copilot · 2026-03-26T13:23:22Z

HMCLCore/src/main/java/org/jackhuang/hmcl/download/java/mojang/MojangJavaDownloadTask.java

+        FileUtils.cleanDirectory(target);

-        public Result(MojangJavaDownloads.JavaDownload download, MojangJavaRemoteFiles remoteFiles) {
-            this.download = download;
-            this.remoteFiles = remoteFiles;
+        if (Files.getFileStore(target).equals(Files.getFileStore(tempDir))) {
+            Files.move(tempDir, target, StandardCopyOption.REPLACE_EXISTING);
+        } else {


postExecute() deletes the existing installation (FileUtils.cleanDirectory(target)) before the final move/copy succeeds. If the subsequent Files.move / copyDirectory fails (I/O error, permissions, antivirus locks, etc.), the user can end up with an empty/broken target. To make this safer, avoid mutating target until the new runtime is fully in place (e.g., move target aside to a backup name, move tempDir into place, then delete the backup; or move tempDir to a sibling target.tmp and swap).

Hylfrd · 2026-03-27T07:34:02Z

帅诶清理底层代码（？）

Glavo · 2026-03-28T12:16:03Z

@sourcery-ai review

Glavo · 2026-03-29T06:55:48Z

@sourcery-ai review

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

HMCLCore/src/main/java/org/jackhuang/hmcl/download/java/mojang/MojangJavaDownloadTask.java

HMCL/src/main/java/org/jackhuang/hmcl/java/HMCLJavaRepository.java

Glavo added 5 commits March 26, 2026 20:26

Convert MojangJavaDownloads to records

0b60bbd

Use pattern matching in MojangJavaDownloadTask

8f67091

Extract Java list URL constant

b23bfe5

Extract Java list URL constant

7392a85

Use temp dir for Java download and verify integrity

4f3b9d6

Glavo requested a review from Copilot March 26, 2026 13:00

Copilot started reviewing on behalf of Glavo March 26, 2026 13:00 View session

Copilot AI reviewed Mar 26, 2026

View reviewed changes

Glavo added 2 commits March 26, 2026 21:14

update

786f8ae

Clean up temp dir after Java download

1f27e74

Glavo requested a review from Copilot March 26, 2026 13:17

Copilot started reviewing on behalf of Glavo March 26, 2026 13:18 View session

Copilot AI reviewed Mar 26, 2026

View reviewed changes

Glavo added 2 commits March 29, 2026 22:10

Add SHA-1 verification for decompressed files in Java download

9012570

update

3f9a5c5

Glavo requested a review from Copilot March 30, 2026 13:23

Copilot started reviewing on behalf of Glavo March 30, 2026 13:24 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

update

fb1229b

-                Files.deleteIfExists(dest);
+                Files.deleteIfExists(dest);
+                Path parent = dest.getParent();
+                if (parent != null) {
+                    Files.createDirectories(parent);
+                }

Conversation

Glavo commented Mar 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Hylfrd commented Mar 27, 2026

Uh oh!

Glavo commented Mar 28, 2026

Uh oh!

Glavo commented Mar 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants