[Bugfix] 使用 tomlj 代替 toml4j 以适配 TOML 标准#5863
Open
Calboot wants to merge 1 commit intoHMCL-dev:mainfrom
Open
Conversation
Member
|
toml4j 和 tomlj 最后一次 commit 均在两年以前，不应使用一个无人维护的库替代另一个无人维护的库 |
Contributor
Author
看了一眼 gradle 读取 toml 的库，用的就是这个，甚至是这玩意的老版本。这证明 tomlj 是得到了认可的。 同时，toml4j 的最后一个 release 是在 2016，而 tomlj 在 2024，差了八年；前者只支持 toml 0.4.0，而后者支持 1.0.0。个人认为这些使得这两个库对于 HMCL 的意义有本质区别。 |
Member
|
哦我知道了，https://github.com/mwanji/toml4j TOML4j 自 2017 年以来的维护都不涉及代码变更，被他骗了…… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5544
https://github.com/tomlj/tomlj