fix(io-options-dialog): surface JSON parse errors to user via info logger (#842)#879
Merged
EdwardMoyse merged 1 commit intoHSF:mainfrom Apr 11, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #842
When a malformed or invalid JSON event file was loaded, Phoenix
crashed silently with no user-facing feedback. The error was only
visible in the browser console.
Changes
Added try/catch blocks around
JSON.parse()calls in:handleJSONEventDataInputhandleEDM4HEPJSONEventDataInputErrors are now surfaced via the existing
getInfoLogger()mechanism,consistent with how
handleZipEventDataInputandhandlePHYSLITEInputalready handle errors.
Before vs After
Before: UI stays completely silent when malformed JSON is loaded
After: User sees clear message in Info Panel:
"Could not parse JSON event file. Please ensure it is valid JSON."Testing
{ "broken":) → error shown in Info Panel