Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Huulivoide
changed the title
* Make sure all relevant elements have ids. * Make sure all items have hard-coded ids. (Diffs) * Make sure all ids are in same format. * Add grouping with multiple `<tbody>`s to HistoryItems.
Huulivoide
force-pushed
the
stop-change-history-e2e
branch
from
5bfc074 to
f3b130a
Compare
suvikankare
approved these changes
Feb 27, 2026
Member
suvikankare
left a comment
suvikankare
left a comment
There was a problem hiding this comment.
@suvikankare reviewed 23 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Huulivoide).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StopChangeHistory: Improve testids
<tbody>s to HistoryItems.E2E: Add ID-list to PageObject utility
StopChangeHistory|E2E: Add initial PageObjects
StopDetails|Measurements: Add testid to
<form>elementStopChangeHistory: Fix Location empty SignContentType enum mapping
StopChangeHistory: Fix percentage formating on Measurements
This change is