Conversation
sycons
left a comment
sycons
left a comment
There was a problem hiding this comment.
These were properly implemented.
- Count values above a threshold ✅
- Debug and Fix the Logic ✅
I've provided feedback on the other tasks. The task wasn't configured to run the tests that were written and binarySearch was not called.
| @@ -0,0 +1,33 @@ | |||
| import {describe , it , expect} from "vitest"; | |||
| import {calculateAverage} from "./calculateAverage"; | |||
There was a problem hiding this comment.
Node is unable to find resolve this import because there are two files that are named calculateAverage minus the file extension.
There was a problem hiding this comment.
I am unable to run the test suite because package.json is missing. This task should be also configured to install the package vitest and have a script that runs the tests.
More info: https://vitest.dev/guide/#adding-vitest-to-your-project
| console.time("linear search 100k"); | ||
| linearSearch(array2, target); | ||
| console.timeEnd("linear search 100k"); | ||
|
|
| console.timeEnd("linear search 10m"); | ||
|
|
||
| console.time("binary search 1k"); | ||
| linearSearch(array1, target); |
There was a problem hiding this comment.
This should call the function binarySearch. Also have a look at the code below this.
sycons
added
Reviewed
2 participants
No description provided.