[WIP] [halium-7.1] main.mk: include halium/biometryd#19
Open
konradybcio wants to merge 1 commit intoHalium:halium-7.1from
konradybcio:fp
Open
[WIP] [halium-7.1] main.mk: include halium/biometryd#19konradybcio wants to merge 1 commit intoHalium:halium-7.1from konradybcio:fp
konradybcio wants to merge 1 commit intoHalium:halium-7.1from
konradybcio:fp
Conversation
Change-Id: I453dc369760f82b009ba2191cc8f702c4cc65bd5
|
@konradybcio Are you sure you PR-ed this against the correct branch? In order for it to pick up biometryd it should exist as well and therefore be pulled in by https://github.com/Halium/android/blob/halium-7.1/default.xml which it's not doing currently it seems? |
Author
|
I only made the PR as a preparation for that. Biometryd still needs some love on Nougat before we can ship it by default. |
|
@konradybcio OK I will keep it pending for now then. Please link to this PR when you put the necessary bits in place elsewhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this ninja won't pick up the directory
Change-Id: I453dc369760f82b009ba2191cc8f702c4cc65bd5