Update deploy condition to explicitly limit to the main branch. Envir…#347
Closed
Update deploy condition to explicitly limit to the main branch. Envir…#347
Conversation
…onment protection limits to main but let's not even try.
| # Only deploy on push to main or manual trigger, not on PRs | ||
| if: (github.event_name == 'push' && github.ref == 'refs/heads/main') || github.event_name == 'workflow_dispatch' | ||
| # Only deploy on push to main or manual trigger from main branch, not on PRs | ||
| if: github.ref == 'refs/heads/main' && (github.event_name == 'push' || github.event_name == 'workflow_dispatch') |
Member
There was a problem hiding this comment.
What if we had a build workflow that ran on everything, and then a deploy workflow that only ever ran on push to main and used the build workflow as a prereq?
Member
Author
There was a problem hiding this comment.
would be nice to cleanup the skipped job in every pr workflow :)
I'll do a bit more of an update when I can get a chance.
Member
|
I'm going to close this. I believe I've made the changes reference here already in the specified workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…onment protection limits to main but let's not even try.