Draft
Conversation
Rudyrue
added a commit
to Cam-VSRG/flixel
that referenced
this pull request
Apr 4, 2026
Geokureli
reviewed
Apr 8, 2026
| public final renderMatrix:FlxMatrix; | ||
|
|
||
| public function new (x = 0.0, y = 0.0, ?simpleGraphic) | ||
| public function new(x:Float = 0.0, y:Float = 0.0, ?simpleGraphic:FlxGraphicAsset) |
Member
There was a problem hiding this comment.
I haven't changed my mind on this PR, yet, but I wanted to note: please don't add types, here. I keep removing these, as the redundancy adds more visual noise than clarity, IMO. I specifically don't want redundant typing when there are default values and on these core OneOfMany asset types where it actually allows multiple types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #3581 this PR implements pooling functionality to FlxMatrix to reduce the number of instances and the memory overhead caused by constantly creating and destroying FlxMatrix objects.
Keeping this as a draft for now since I believe I should implement uses of the pooling inside of the HaxeFlixel codebase first before setting it ready to merge.