fix: Sized image dimensions are lost upon page reload (image shows up again as 100% full width) 🤖 #1158
Open
mrjbj wants to merge 2 commits intoHiEventsDev:developfrom
Open
fix: Sized image dimensions are lost upon page reload (image shows up again as 100% full width) 🤖 #1158mrjbj wants to merge 2 commits intoHiEventsDev:developfrom
mrjbj wants to merge 2 commits intoHiEventsDev:developfrom
Conversation
ImageResize had name 'imageResize' while base Image (name 'image') was also registered. TipTap parsed <img> tags with the base extension, which lacks renderHTML for style, so resized dimensions were lost on save/reload. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Without renderHTML, resized image dimensions are only stored in parseHTML but not serialized back to the document, causing them to be lost on reload. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Body:
What changes I've made
ImageResizeextension from'imageResize'to'image'so it fully replaces the base TipTap Image extensionImageextension registration from the EditorWhy I've made these changes
Resized image dimensions are lost on save/reload. Both the base
Image(name:'image') andImageResize(name:'imageResize') extensions were registered simultaneously. When TipTap parses saved HTML, it matches<img>tags to the'image'node type — the base extension, which doesn't persist thestyleattribute. By renamingImageResizeto'image'and removing the base, the resize-aware extension fully owns<img>parsing and preserves dimensions.How I've tested these changes
Checklist