cask/artifact: enable Sorbet typed: strict for abstract classes
#21486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduugg
force-pushed
the
cask-artifact-strict-typing
branch
from
5c529eb to
f24c7aa
Compare
dduugg
commented
Jan 31, 2026
| @directives = directives | ||
| end | ||
|
|
||
| def install_phase(**) |
Member
Author
There was a problem hiding this comment.
The switch from anonymous kwargs should be unecessary if sorbet/sorbet#9857 is accepted and released, in case that's something we want to wait on
dduugg
force-pushed
the
cask-artifact-strict-typing
branch
from
f24c7aa to
13ad19f
Compare
Enable strict typing for the abstract base classes in `Cask::Artifact`: - `AbstractArtifact` - `AbstractFlightBlock` - `AbstractUninstall` - `Relocated` This adds proper type signatures to all methods and updates the typing level from `typed: true` to `typed: strict`. Also marks `english_name` and `dirmethod` as `overridable` in `AbstractArtifact` and adds `override` to subclasses that override them. Advances #17297
dduugg
force-pushed
the
cask-artifact-strict-typing
branch
from
13ad19f to
a470303
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Enable strict typing for the abstract base classes under
Cask::Artifact:AbstractArtifactAbstractFlightBlockAbstractUninstallThis adds proper type signatures to all methods and updates the typing level from
typed: truetotyped: strict.Also marks
english_nameanddirmethodasoverridableinAbstractArtifactand addsoverrideto subclasses that override them.Advances #17297