Conversation
|
Should I make this PR against main or the v1.1.9 branch? |
|
v1.1.9 for staging is fine. |
|
hmmm. ' is mostly from too much programming in php :P it is faster to type, but i suppose " is more standard in python and other languages. |
|
|
||
| # Evaluate the expression | ||
| end_value = eval(compile(tree, filename='', mode='eval')) | ||
| end_value = ast.literal_eval(compile(tree, filename="", mode="eval")) |
There was a problem hiding this comment.
oops, yeah ima n00b. there is a safer eval option ;)
Ah, I could have switched it to use single. :) Yes, to the PHP as well. I have a massive PHP project I developed for internal use at work. I've been using phpstan to handle linting/checks/style and it's been an absolutely glorious thing. That's mainly why I've been implementing this in my python projects, and even my bash-based ones. |
2 participants
This PR is a bit massive because it touches so many files. It is primarily due to the (Q) rule which comes from flake8 to use double quotes. I noticed an inconsistent usage of single and double throughout the code. If you prefer single, ruff can be configured to enforce single instead.