Make NativeDate.toLocaleString() behave more like real browsers#20
Open
duonglaiquang wants to merge 1 commit intoHtmlUnit:masterfrom
Open
Make NativeDate.toLocaleString() behave more like real browsers#20duonglaiquang wants to merge 1 commit intoHtmlUnit:masterfrom
duonglaiquang wants to merge 1 commit intoHtmlUnit:masterfrom
Conversation
Member
|
No access to my pc today, will work on this tomorrow |
Member
|
Great, forwarded to Rhino, i this will be merged after some review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following
Make
toLocaleString(),toLocaleDateString(), andtoLocaleTimeString()output closer to real browser behavior by building DateTimeFormatter dynamically using the resolved locale instead of static pre-built formatters.Now the outputs are almost identical to real browser with the exception of some minor cases.