Support asynchronous human preference gathering in RLHP implementation #716
Open
mschweizer wants to merge 165 commits intoHumanCompatibleAI:masterfrom
Open
Support asynchronous human preference gathering in RLHP implementation #716mschweizer wants to merge 165 commits intoHumanCompatibleAI:masterfrom
mschweizer wants to merge 165 commits intoHumanCompatibleAI:masterfrom
Conversation
… into human-pref-gatherer
Co-authored-by: Robert Klassert <robertklassert@pm.me> Co-authored-by: Marvin Schweizer <marvin.schweizer@gmail.com>
# Conflicts: # src/imitation/algorithms/preference_comparisons.py
Refactor human prefs
…into human-prefs-base
…fs-base # Conflicts: # src/imitation/algorithms/preference_comparisons.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing
We added extensive unit tests in test_preference_comparisons.py
Tests for 2 utility methods are currently missing and some existing tests still need fixing.