Skip to content

SCENARIO: Page title should be updated when the user goes back to the bookshelf (see #174)#391

Draft
gd-utt wants to merge 2 commits intomainfrom
fix-174
Draft

SCENARIO: Page title should be updated when the user goes back to the bookshelf (see #174)#391
gd-utt wants to merge 2 commits intomainfrom
fix-174

Conversation

@gd-utt
Copy link
Copy Markdown

@gd-utt gd-utt commented Mar 24, 2026

We, Gabriel DOSNE gabriel.dosne@utt.fr and Morgane VIALA morgane.viala@utt.fr and Arthur DE PÉTIGNY SAINT ROMAIN arthur.de_petigny_saint_romain@utt.fr, hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.

@benel
Copy link
Copy Markdown
Member

benel commented Mar 31, 2026

@AdePeti @gd-utt @Lysakolie Thank you for your contribution.

Your git history has to be edited so that, for scenarios, you have:

I strongly recommend using Git Fork for the intensive git history rewriting done in IF05.

Copy link
Copy Markdown
Member

@benel benel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @AdePeti @gd-utt @Lysakolie

Here are a few changes to bring to your scenarios file.


Scénario: au bookshelf

Soit "Les fables de La Fontaine" le document principal
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title will be converted into an HTTP-URI.
Therefore you have to choose a title that was already used.
You can look at those:

Scénario: au bookshelf

Soit "Les fables de La Fontaine" le document principal

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superfluous blank line


Quand j'essaie de revenir au bookshelf
Alors je suis sur la page bookshelf
Et le titre de l'onglet est Hyperglosae
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could put brackets around "Hyperglosae".

By doing this you could reuse the step before the When to test that the page title is the same as the one you opened.

Soit "Les fables de La Fontaine" le document principal

Quand j'essaie de revenir au bookshelf
Alors je suis sur la page bookshelf
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation for "bookshelf" in French is "étagère".


Soit "Les fables de La Fontaine" le document principal

Quand j'essaie de revenir au bookshelf
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation for "bookshelf" in French is "étagère".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants